mahara-contributors team mailing list archive

[Mahara Bot <1892106@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11157
Committed: https://git.mahara.org/mahara/mahara/commit/bcdebe61933dcb3d6bece59f6c433961db594400
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit bcdebe61933dcb3d6bece59f6c433961db594400
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 19 12:07:22 2020 +1200

Bug 1892106: Adding hasconfig value to external_functions table

So that functions can alert if they have special config

And check for the service functions that have special config

Change-Id: Ic2bc5ddc1e39f403d1b2583f6d18ec99919d3ffa
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892106

Title:
  Allow webservices external apps to show configuration options based on
  functions it contains

Status in Mahara:
  Fix Committed

Bug description:
  Currently the LTI module has the ability to configure the following 2 options:
  - autocreateusers
  - parentauth

  And they are used in the module_lti_launch function.

  But if we make a custom webservice and include module_lti_launch as
  one of it's services we have no way (apart from directly on database)
  to set these options

  Currently the webservice/admin/oauthv1sregister.php page shows the config cog if a module has 
  has_oauth_service_config() set to true and displays the config form via get_oauth_service_config_options()

  But what we should have is some code that checks if the webservice
  contains functions that have config options and then display the
  button / form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892106/+subscriptions