mahara-contributors team mailing list archive

[Mahara Bot <1887450@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11245
Committed: https://git.mahara.org/mahara/mahara/commit/4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Sep 1 15:05:24 2020 +1200

Bug 1887450: Block header buttons need better labels when Editing Pages

- add in sr-only tags for buttons

Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac)
(cherry picked from commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887450

Title:
  Block header buttons need better labels when Editing Pages

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  It was found that the labels for the buttons that appear when editing
  a block on a page are not accurately described by a screen reader.
  The buttons are "Configure block" and "Remove block".  The "Remove
  block" button was entirely missing its label for screen readers, while
  the "Configure block" reads "Move block" instead of configure block.

  It looks like the 'sr-only' class needs to be applied correctly to the
  configure block button so that it misses the move button text and
  addresses its own purposes and for it to be applied to the remove
  block button in blocktypecontainerediting.tpl

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions