mahara-contributors team mailing list archive

[Mahara Bot <1892256@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11250
Committed: https://git.mahara.org/mahara/mahara/commit/b9513c750d5fb8da22a6ada5a9d7fcae4f7a9898
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit b9513c750d5fb8da22a6ada5a9d7fcae4f7a9898
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Aug 20 09:33:19 2020 +1200

Bug 1892256: Restructure code to avoid Undefined variable: duplicates

Change-Id: Ia93f67a0aa3558dda1ae7677b84202f0f07e446e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit ce09693205cb9b8fe8a2f949cb09aeca2c197dc4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions