← Back to team overview

mahara-contributors team mailing list archive

[Bug 1894026] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11218
Committed: https://git.mahara.org/mahara/mahara/commit/a6af81231c2746fdf7c3ed7a12cf8e689bc21f42
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a6af81231c2746fdf7c3ed7a12cf8e689bc21f42
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Thu Sep 3 17:22:49 2020 +1200

Bug 1894026: fetch js from correct folder in html exports

behatnotneeded

Change-Id: I6a58c9c9a1f314ae17b838aa0ca72f201caec351

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1894026

Title:
  exports: js files are fetched from the wrong dir in configurable theme

Status in Mahara:
  Fix Committed

Bug description:
  when generating the 'All my data' export the html files created have
  the wrong path for the javascript files, if the logged in user
  exporting the data belongs to an institution using a configurable
  theme

  To replicate
  - have an institution with configurable theme set up
  - have a member of that institution and login as that user
  - go to User menu -> Manage -> Export
  - select 'All my data' and click on 'Generate export'
  - extract the downloaded .zip file is a local directory
  - open the HTML/index.html file
  - inspect the code in the browser

  Expected result: the path of the .js file, e.g. jquery.js, should be pointing to the HTML/static/theme/raw but the theme.js file that is located in HTML/static/theme/custom
  Actual result: the path of some of the .js file (not theme.js) starts with HTML/static/theme/custom

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1894026/+subscriptions


References