mahara-contributors team mailing list archive

[Mahara Bot <1894756@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11237
Committed: https://git.mahara.org/mahara/mahara/commit/14784ea0219607284bbccb6059484e9d9c904fad
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 14784ea0219607284bbccb6059484e9d9c904fad
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Sep 8 09:10:16 2020 +1200

Bug 1894756: Set extra headers correctly for client_connnection

So that the wstoken is seperate from extra headers and we can define
the full header in form field

Also have the correct nav menu when editing connection

Change-Id: I12a3b8d699d8da55718dba81c9ad31cfab9d2300
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1894756

Title:
  Client connections setting headers incorrectly

Status in Mahara:
  Fix Committed

Bug description:
  If using a client connection and you turn on use headers and supply a
  header it fails to work

  Scenario

  Mahara is trying to call a webservice connection via a
  client_connection via REST protocol to an external site but the
  external site is behind basic authentication so you choose the 'use
  headers' option and put in a basic auth header, eg "Authorization:
  Basic dGVtcDpBZTlhZWtveg" but it fails to work.

  The problem is the code for adding this to the $auth array mixes up
  parts of the wstoken and the header so breaking the call

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1894756/+subscriptions