mahara-contributors team mailing list archive

[Mahara Bot <1891941@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11160
Committed: https://git.mahara.org/mahara/mahara/commit/c276f708abdc9b19dc7e46d9445507d6d74bf88c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c276f708abdc9b19dc7e46d9445507d6d74bf88c
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Aug 20 16:24:53 2020 +1200

Bug 1891941: Correct inbox notifications for collection access

- separate email, html and internal notifications into 2 different templates
- remove email only information from internal notification
- fix formatting for internal notification
- alter the 'More...->' url to go to the portfolio when sharing either one
page or one collection, go to sharedviews otherwise.
- when sharing a single page or single collection change 'More...->' to read
'Portfolio...->' or 'Collection...->'

Change-Id: Ie52afc3ed9f4729f2171f79a563ba74d1d2dc7a3
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891941

Title:
  Correct inbox notifications for collection access

Status in Mahara:
  Fix Committed

Bug description:
  This is a follow-on from bug #922911 and marked as high as new
  functionality.

  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:

  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one
  item though, there shouldn't be a list, but just the item as lists
  start with two items.

  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.

  3. The 'More... ->' link should read 'Portfolio ->' instead and have
  an accessible title that mentions the portfolio title.

  4. The notification should start with 'You have been given access to'
  but not repeat the subject.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891941/+subscriptions