← Back to team overview

mahara-contributors team mailing list archive

[Bug 1895617] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11273
Committed: https://git.mahara.org/mahara/mahara/commit/55eab846df7c51d2dfc1acf18cdd07157414ec97
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 55eab846df7c51d2dfc1acf18cdd07157414ec97
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Sep 15 16:31:11 2020 +1200

Bug 1895617: export html check for directory readability needs to match
directory used

- remove the '/' from directoriestocopy array

Change-Id: I4462a7f0b17c153af750569f72f8476e9fe1977f
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895617

Title:
  export html check for directory readability needs to match directory
  used

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  In export/html/lib in the copy_static_files() we have the lines:

      if (is_readable($dir . $static)) {...etc...}

  but when we later populate the directories we want to copy we use:
  $directoriestocopy[$dir . '/' . $static] which uses a different path.
  This also adds an extra unneccesary directory level '/'.
  We need to make these paths consistent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895617/+subscriptions


References