mahara-contributors team mailing list archive

[Mahara Bot <1895901@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11278
Committed: https://git.mahara.org/mahara/mahara/commit/5b0a7106f793b2adef665773945013d5eeda04f8
Submitter: Lisa Seeto (lisaseeto@xxxxxxxxxxxxxxx)
Branch:    master

commit 5b0a7106f793b2adef665773945013d5eeda04f8
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Sep 17 10:57:50 2020 +1200

Bug 1895901: Make sure we only call included files once

Otherwise we can end up with
PHP Fatal error:  Cannot redeclare serve_file() (previously declared
in htdocs/lib/file.php:38) in htdocs/lib/file.php on line 171

Change-Id: I020393a395543738c9054783698e2665160308f8
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895901

Title:
  Getting PHP Fatal error:  Cannot redeclare serve_file() when using
  sync_langpacks

Status in Mahara:
  New
Status in Mahara 19.04 series:
  New
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  New

Bug description:
  This is because we are using require() instead of require_once() in
  sync_langpacks.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895901/+subscriptions