mahara-contributors team mailing list archive

[Mahara Bot <1892426@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11188
Committed: https://git.mahara.org/mahara/mahara/commit/554d4f1221069febe52681baf1814c8628b07ee0
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 554d4f1221069febe52681baf1814c8628b07ee0
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Wed Aug 26 14:53:11 2020 +1200

Bug 1892426: Help icon text missing in certain file browser modals

- added in another pattern to regex for preg_replace

Change-Id: I41a9d451fea0ba185384d2c2acd5aa6900a4781b
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892426

Title:
  Help icon text missing in certain file browser modals

Status in Mahara:
  Fix Committed

Bug description:
  When you add an attachment to a journal entry or to 'Goals and skills'
  in the resume or add a cover image, the help icons for the license
  metadata do not display the actual help text. It's always using the
  same method.

  To replicate:

  1. Turn on 'License metadata' in 'Configure site' -> 'Site options'.
  2. Create a journal entry.
  3. Click the 'Add a file' button under 'Attachments'.
  4. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  5. Go to 'Goals and skills' in the resume.
  6. Edit one of the goals.
  7. Click the 'Add a file' button under 'Attachments'.
  8. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  Once implemented, check that the help icon text still displays
  correctly for the following:

  a) Main menu -> Create -> Files
  b) in the block 'File(s) to download'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892426/+subscriptions