← Back to team overview

mahara-contributors team mailing list archive

[Bug 1539322] Re: Do we still need device detection?

 

TinyMCE has advanced and has a good mobile interface. The change Cecilia
made in https://reviews.mahara.org/11075 allows to swipe even when
device detection is turned on. I don't think we need this library any
more only to hide the import and export buttons. When sites have 'Export
via queue' enabled, the export could be triggered from a mobile device
and completed on a regular computer.

** Changed in: mahara
    Milestone: None => 21.04.0

** Summary changed:

- Do we still need device detection?
+ Remove mobile device detection

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539322

Title:
  Remove mobile device detection

Status in Mahara:
  Triaged

Bug description:
  Mahara 15.10 introduced Bootstrap. All themes are now responsive. When
  I tested the "Deactivate device detection" functionality, I couldn't
  see much of a difference when using the site. I did notice the content
  chooser was displayed the start of the words instead of only showing
  the icon on the "Edit page" screen.

  I wonder if we can remove the custom device detection. You can enable
  the user turning off device detection in Admin -> Config site -> User
  settings -> Users can disable device detection. That then happens on
  the account settings page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions


References