← Back to team overview

mahara-contributors team mailing list archive

[Bug 1749308] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11075
Committed: https://git.mahara.org/mahara/mahara/commit/4f4ab38ded7b59a2c92816ef8acc67c9a7464334
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 4f4ab38ded7b59a2c92816ef8acc67c9a7464334
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Mon Jul 20 16:52:15 2020 +1200

Bug 1749308: Add collection swipe events if on touch device

behatnotneeded

Change-Id: Icf8b861c6d2e6f3b9f0775b5b3c35aa3783accc5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749308

Title:
  Collection navigation triggering swiperight event on mouse click

Status in Mahara:
  Fix Committed

Bug description:
  Mahara: 17.10.3
  OS: Linux 16.04
  DB: Postgres (not relevant)
  Browser: Firefox and Chrome

  
  In a collection on a view with the 'Previous page' displayed, the swiperight event is getting triggered on a mouse click. 

  When a user tries to select some text (i.e. click mouse, hold it down,
  and select text), this action is interpreted as a swipe action. And,
  the swiperight event is triggered.

  I've come across this stackoverflow discussion:

  https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-
  gesture-for-touch-screen-only-and-not-for-mouse

  Bascially, the swiperight and swipeleft events should be disabled on
  the mousedown event and enabled on the touchstart event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions


References