mahara-contributors team mailing list archive

[Mahara Bot <1896352@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11295
Committed: https://git.mahara.org/mahara/mahara/commit/9f83c8796a3e413ae600bf0881673faa74236dd0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 9f83c8796a3e413ae600bf0881673faa74236dd0
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Mon Sep 21 20:49:00 2020 +1200

Bug 1896352: Error when adding LTI connection: 'component' not available

Add check to see if consumer is true

behatnotneeded

Change-Id: I1dae492acb1c47c68e0a10428f742092776b588f
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1896352

Title:
  Error when adding LTI connection: 'component' not available

Status in Mahara:
  Fix Committed

Bug description:
  Mahara master:

  When I try to add 'LTI integration' to 'No institution', I get the
  following error message:

  [WAR] 59 (webservice/admin/oauthv1sregister.php:772) Trying to get property 'component' of non-object
  Call stack (most recent first):

      log_message("Trying to get property 'component' of non-object", 8, true, true, "/home/kristina/code/mahara/htdocs/webservice/admin...", 772) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
      error(8, "Trying to get property 'component' of non-object", "/home/kristina/code/mahara/htdocs/webservice/admin...", 772, array(size 2)) at /home/kristina/code/mahara/htdocs/webservice/admin/oauthv1sregister.php:772
      get_module_from_serverid("2") at /home/kristina/code/mahara/htdocs/webservice/admin/oauthv1sregister.php:92
      webservices_add_application_submit(object(Pieform), array(size 6)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:568
      Pieform->__construct(array(size 8)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:168
      Pieform::process(array(size 8)) at /home/kristina/code/mahara/htdocs/lib/mahara.php:5506
      pieform(array(size 8)) at /home/kristina/code/mahara/htdocs/webservice/admin/oauthv1sregister.php:642
      webservice_server_list_form(array(size 3), array(size 1)) at /home/kristina/code/mahara/htdocs/webservice/admin/oauthv1sregister.php:68

  ------------

  It is not a problem when trying to add 'LTI integration' to an
  institution.

  It is also not a problem when adding 'LTI integration' to 'No
  institution' when an institution exists.

  To replicate:

  1. Make sure you do not have any institutions on the site and only 'No institution'.
  2. Go to Admin menu -> Web services -> External apps.
  3. Create an 'LTI integration' connection for 'No institution'.
  Expected result: The connection is created.
  Actual result: The connection is created but with the error message above.

  To test once fixed:

  a) The above scenario
  b) The scenario but with an institution
  c) The scenario but with 'No institution' when an institution is available

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1896352/+subscriptions