mahara-contributors team mailing list archive

[Mahara Bot <1897829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11340
Committed: https://git.mahara.org/mahara/mahara/commit/5d1639dc14d9e786c081a82aae12bb1a5e723333
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit 5d1639dc14d9e786c081a82aae12bb1a5e723333
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Oct 1 15:13:50 2020 +1300

Bug 1897829: Choosing details in image gallery opens a blank modal

- check if artefact isset
- only pass through artefactid if it exists

Change-Id: I65f70a7fffffd938646bac257cc0a461514115a2
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit e5ef210e101275ff154ec69374063fa18018736b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897829

Title:
  20.10RC1: Choosing details in image gallery opens a blank modal

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Using QA Mahara with the following settings on Windows:
  PHP 7.4
  Postgres 10.9
  Skins enabled
  Individual themes enabled
  Pre-populated data
  Maroon theme

  Also exists in master on Ubuntu 18.10 and postgres with Ocean theme

  Steps:
  As a person with a page, add an image gallery with 5 images.
  Save the page and display it.
  Click the magnifying glass icon and the resulting details icon

  Expected:
  A modal appears with details of the image gallery block

  Actual:
  A blank modal appears

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897829/+subscriptions