← Back to team overview

mahara-contributors team mailing list archive

[Bug 1897670] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11344
Committed: https://git.mahara.org/mahara/mahara/commit/fb7492be621d460287c7114e57d955a147828077
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit fb7492be621d460287c7114e57d955a147828077
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Fri Oct 2 13:53:15 2020 +1300

Bug 1897831 Slant edge of Maroon theme not rendering correctly

Changed to use mixin and transform to do the slant which has better
browser support. Used it for header, pageheader, and footer. Also
meant the header could now be sticky at the top like other themes.

This should also fix Bug 1897670.

behatnotneeded

Change-Id: I54e2143e048352bdc4f2dbec60bc317c25ac7204
(cherry picked from commit bdcfbacbdd43275c21d895e7fbac7ff46055bea1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897670

Title:
  2010RC1: Skins in maroon theme

Status in Mahara:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  In Progress

Bug description:
  Using QA Mahara with the following settings on Windows:
  PHP 7.4
  Postgres 10.9
  Skins enabled
  Individual themes enabled
  Pre-populated data

  Maroon theme

  Steps taken:
  Create a skin with the following:
  - Header background image

  - Page background image
    Background image repeat: Repeat both directions
    Background image attachment: Scroll
    Background image position: Top left

  Save and apply to a page.

  The page background image stops in a horizontal line before it reaches
  either the header or the footer. (See screenshot)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897670/+subscriptions


References