mahara-contributors team mailing list archive

[Robert Lyon <1898762@xxxxxxxxxxxxxxxxxx>]

Thank you Octavio Jr for this report the change has been added to the
related branches and will be available in next release

** Changed in: mahara/19.10
    Milestone: None => 19.10.5

** Changed in: mahara/20.04
    Milestone: None => 20.04.2

** Changed in: mahara/20.10
    Milestone: None => 20.10.0

** Changed in: mahara/19.10
   Importance: Undecided => Medium

** Changed in: mahara/20.04
   Importance: Undecided => Medium

** Changed in: mahara/20.10
   Importance: Undecided => Medium

** Changed in: mahara/19.10
       Status: New => Fix Committed

** Changed in: mahara/20.04
       Status: New => Fix Committed

** Changed in: mahara/20.10
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898762

Title:
  Regression memcached servers

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Analising mahara 20.04.1 I see and regression on here :
  https://github.com/MaharaProject/mahara/blob/20.04_STABLE/htdocs/auth/lib.php#L681

  
  Instead of this

                  if (empty($server_version[$host . ':' . $port])) {
                      $is_configured = false;
                  }

  It should be this : 
                  if (!empty($server_version[$host . ':' . $port])) {
                      $is_configured = true;
                  }

  
  I tried to configured a memcached server and had an erreur as settings memcacheservers weren't set.

  In the code since $is_configured is already false, we have to invert
  the logic to see if a server is configured or not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898762/+subscriptions