mahara-contributors team mailing list archive

[Mahara Bot <1899120@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11367
Committed: https://git.mahara.org/mahara/mahara/commit/be234d5838bca0339116516322b9717ab7a2f38b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit be234d5838bca0339116516322b9717ab7a2f38b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Oct 14 13:57:07 2020 +1300

Bug 1899120: button style on confirm popup privacy modal

to test:
1) Set site option -> institution -> strict privacy on
2) Go to Account -> settings -> legal and set no to one of the options
and hit save at bottom
- a modal should pop up with a confirm form
- it is the buttons here that were not styled right

Change-Id: I2a9c155beb056375a3ea9931d21ecd4bd58306c7
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1899120

Title:
  Incorrect button classes on submitcancel buttons 20.04

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to: https://bugs.launchpad.net/mahara/+bug/1898955

  While testing the above fix I looked for "submitcancel" in .tpl files
  to see whether there were other cases with "btn-primary" and without
  "btn" class. I found the following:

  /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl
  /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl
  /htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl
  /htdocs/theme/raw/templates/privacy_modal.tpl

  I confirmed the first three do display incorrect styling for the submitcancel button group.
  Screenshots below.

  Limitations
  Note: This affects 20.04, but not 20.10+
  Only buttons using the "submitcancel" class have been searched for. It is possible there are other similar issues with other button classes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1899120/+subscriptions