mahara-contributors team mailing list archive

[Mahara Bot <1835681@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11370
Committed: https://git.mahara.org/mahara/mahara/commit/0c273d78dfb5dbbf2b33cbbefe7cd1b518fe604b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit 0c273d78dfb5dbbf2b33cbbefe7cd1b518fe604b
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Oct 8 11:22:10 2020 +1300

Bug 1835681: Check if we still need the config parameter "developermode"

- removed all references related to  developermode

Change-Id: Iffa362d6f273445dc7be41a654e086a4e289bcee
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit 33f1dce0495276a92dcb56e8d739e380aedd395d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1835681

Title:
  Check if we still need the config parameter "developermode"

Status in Mahara:
  Fix Committed

Bug description:
  There is the config.php parameter "developermode". It says in /lib
  /config-defaults.php:

   * @global int|bool $cfg->developermode Developer mode
   * When set, the following things (among others) will happen:
   *
   * * 'debug.css' will be included on each page. You can edit this file to add
   *   debugging CSS at your discretion
   * * the unpacked version of MochiKit will be used
   *
   * These options are a performance hit otherwise, enable when you are
   * developing for Mahara
   */
  $cfg->developermode = false;
  // $cfg->developermode = DEVMODE_DEBUGCSS | DEVMODE_UNPACKEDJS;

  ---

  It would need to be checked what "among others" is. We are not using
  debug.css and Mochikit has been removed. Before we get rid of the
  parameter though, it would need to be checked if removing it impacts
  anything else.

  Once the analysis is available, we can make a decision.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1835681/+subscriptions