← Back to team overview

mahara-contributors team mailing list archive

[Bug 1898652] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11351
Committed: https://git.mahara.org/mahara/mahara/commit/d6781e3f1afd33cbdc5fd71f609bdf0e257d4c8d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d6781e3f1afd33cbdc5fd71f609bdf0e257d4c8d
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Oct 9 09:03:31 2020 +1300

Bug 1898652: Avoid sending pdf browser check in response payload

The download serving for pdf export also sends back the buffer info
for the chrome browser check and therefore errors out the json with
parse error

We can avoid this by clearing the buffer after making the pdfs

Change-Id: I74991a3f80198f4f15e547b7b12c8ee68fd4ec36
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898652

Title:
  Bulk export not working correctly when doing PDF export

Status in Mahara:
  Fix Committed

Bug description:
  When the code was first written the PDF export put the .pdf files in
  the HTML subdir next to the .html pages

  But now we separate the HTML and PDF sections so we need to make sure
  the PDF files are added to the zip files.

  To test:

  1) Have a few users with a few pages each
  2) Go to admin/users/bulkexport.php and select 'PDF' export type
  3) Put in the usernames for the three users, 1 per line

  Export

  Problem 1: the export progress bar doesn't tick up correctly
  Problem 2: eventually the zip file is made but only contains the HTML section and not the PDF and export_info directories

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898652/+subscriptions


References