← Back to team overview

mahara-contributors team mailing list archive

[Bug 1898123] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11389
Committed: https://git.mahara.org/mahara/mahara/commit/fbb8fe17b593fac2d55c6cb0d2f15adb9bd9740c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit fbb8fe17b593fac2d55c6cb0d2f15adb9bd9740c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 15 11:05:18 2020 +1300

Bug 1898123: Make the cog icon be beside text again

The parent patch broke this on firefox/ubuntu
This change hopefully fixes the problem

Change-Id: Icf01ae8d28bd2f355f9aeb5751ab75c07f631036
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit e1e772da22f1759827863a18af1d49dfb9aeb897)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898123

Title:
  iOS-Safari tablet - long block detail modal title overlaps block
  content

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Environment: master.dev 
  Browser: iOS 14.1 with Safari on iPad Air 2 (10") portrait

  Precondition: Logged in account has a page with an image block on it
  that has a long (45+characters) file name (see attached screen shot).

  Steps
  1. Log in and choose to view the page, select to view the block details and comments bars.
  2. Select the image block's details and comment bar.

  Expected result: the image's details modal opens and displays correctly.
  Actual result: the image's details modal opens but as the title does not fit on one line, its display wraps and it covers the 'Preview' heading (see attached screen shot).

   
  NOTE: this is not a problem when viewing the same modal using the 8" Android-Chrome device - in this case the grey title area is extended to two lines and the 'Preview' title displays beneath it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898123/+subscriptions


References