← Back to team overview

mahara-contributors team mailing list archive

[Bug 1898502] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11440
Committed: https://git.mahara.org/mahara/mahara/commit/815637ad5ae05306c3fbe8f567807f44638c8222
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit 815637ad5ae05306c3fbe8f567807f44638c8222
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Wed Nov 11 14:40:36 2020 +1300

Bug 1898502: Android tablet - TinyMCE editor allows all 6 heading sizes

- restrict the heading styles on mobile theme
- update README with change details

Change-Id: Id1c681dd26711d8483bb6490ba710e072a69229a
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit 80c392874822bf5aaaa31b0a17c504af57a3a50d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898502

Title:
  Android tablet - TinyMCE editor allows all 6 heading sizes

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed

Bug description:
  Environment: master.dev
  Platform/s: Android versions 7 & 9 with Chrome and also Firefox

  Release 20.10 uses TinyMCE version 5.0 which is now described on their
  web-site as 'legacy' for mobile, fixing this may require upgrading
  TinyMCE.  Web site: https://www.tiny.cloud/docs/mobile/

  Precondition: Logged in person has a page with a text block.

  Steps:
  1. Logged in user chooses to edit a text block (tap block), selects some text to make into a heading, and using the 'T' option selects to view the 'Styles' Headings options and selects a heading style (should only be 3 choices available).

  Expected results: only three headings are available for selection (and
  when the updated page is viewed and the heading 'Inspected', it shows
  use of either h4, h5 or h6).

  Actual result: there are 6 options available and if 'Heading 1' is
  selected, when the updated page is viewed and the heading 'Inspected',
  it shows use of h1.

  Refer to Bug #1895213

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898502/+subscriptions


References