← Back to team overview

mahara-contributors team mailing list archive

[Bug 1904627] [NEW] The 'favorite' system not actually being used in Mahara currently

 

Public bug reported:

There was a system called 'favorites list' that was added in a series of
patches with commit ids

14ad642ca2c26b0f659e98d17967903f3860d80d
1d4b387f992a772d00d54b7b56a82950029e63f8
d8516bcee8bdffc9351e6e04bcabd6bdb1278c1c
58e48b4f88bc2f4451fb79029ebfcb1ade5ab715

in June 2011. This change looks to be meant for the view access form so
that a list of favourite people could be selected rather than granting
access to each individually.

But currently the only way to add people to the list is via webservices
and there the view access form doesn't display them so therefore we
can't save the rule against a portfolio

So going forward do we want to either:

Remove the code for favorites as it is a dead idea

or:

Fix things so that a favorites list can be created by a person or
institution within the system and have it display correctly in view
access form

My vote is on removing the code as now we have the auto-complete search
for a particular user happening in view access page

** Affects: mahara
     Importance: Wishlist
         Status: New

** Changed in: mahara
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1904627

Title:
  The 'favorite' system not actually being used in Mahara currently

Status in Mahara:
  New

Bug description:
  There was a system called 'favorites list' that was added in a series
  of patches with commit ids

  14ad642ca2c26b0f659e98d17967903f3860d80d
  1d4b387f992a772d00d54b7b56a82950029e63f8
  d8516bcee8bdffc9351e6e04bcabd6bdb1278c1c
  58e48b4f88bc2f4451fb79029ebfcb1ade5ab715

  in June 2011. This change looks to be meant for the view access form
  so that a list of favourite people could be selected rather than
  granting access to each individually.

  But currently the only way to add people to the list is via
  webservices and there the view access form doesn't display them so
  therefore we can't save the rule against a portfolio

  So going forward do we want to either:

  Remove the code for favorites as it is a dead idea

  or:

  Fix things so that a favorites list can be created by a person or
  institution within the system and have it display correctly in view
  access form

  My vote is on removing the code as now we have the auto-complete
  search for a particular user happening in view access page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904627/+subscriptions


Follow ups