mahara-contributors team mailing list archive

[Mahara Bot <1899855@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11433
Committed: https://git.mahara.org/mahara/mahara/commit/e3b87abae3ab2166150680f95a78637038c35aa5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit e3b87abae3ab2166150680f95a78637038c35aa5
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Nov 11 10:30:35 2020 +1300

Bug 1899855: Created lang strings for hardcoded string literals in
webservices/functions

Better maintenance to have keep strings used in webservices as lang strings rather than
hardcoding them in.

behatnotneeded

Change-Id: I70d54e89865b4ea35bc5762eb02b47e9cbc0a105

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1899855

Title:
  Update the webservices variables help text - currently hardcoded in
  english

Status in Mahara:
  Fix Committed

Bug description:
  The need to be changed to language strings eg these files
  htdocs/webservice/functions/mahara_*_external.php

  and these parts, eg

  new external_value(PARAM_RAW, 'Username of the assessment submitter',
  VALUE_OPTIONAL, null, NULL_ALLOWED, 'id'),

  the 'Username of the assessment submitter' needs to be
  get_string('usernameassessmentsubmitter', 'webservices')

  And we make a htdocs/lang/en.utf8/webservices.php for them

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1899855/+subscriptions