mahara-contributors team mailing list archive

[Mahara Bot <1904352@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11448
Committed: https://git.mahara.org/mahara/mahara/commit/bf1139f111ec64ec1a454875001a802d88cd9abe
Submitter: Lisa Seeto (lisaseeto@xxxxxxxxxxxxxxx)
Branch:    master

commit bf1139f111ec64ec1a454875001a802d88cd9abe
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Nov 16 10:35:46 2020 +1300

Bug 1904352: Save navigation block correctly

Depending if the other pages in collection are in old or new layout

Change-Id: Ic6a395e391614e285338b8f6e3c900383cec4113
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1904352

Title:
  Adding navigation block to a collection can cause loss of data

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed

Bug description:
  When doing the following scenario the display of a page can be
  adversely affected

  1) Have a collection of pages that were made before the new grid
  layout was added, eg before September 2019, that don't have navigation
  blocks in them. A good test is to have an image block on each page.

  2) Go to edit one of the pages - it should prompt you to convert the
  page to the new grid layout - choose the 'Accept' option

  3) Add a navigation block to the page and set 'Add to all pages' to
  'Yes'

  4) Save the block

  Now go view the collection - the page you edited should look normal
  but the other pages will now be missing all blocks except the
  Navigation one

  Luckily the data is not deleted but just that the new navigation block
  for those pages has been saved as a block with new grid layout
  information so the page is rendered as a new layout page.

  What we need to do is save the navigation block onto the pages in old
  layout way so that it all displays again as expected.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904352/+subscriptions