mahara-contributors team mailing list archive

[Mahara Bot <1831415@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11487
Committed: https://git.mahara.org/mahara/mahara/commit/f44a8f45ed1316dbb06516e959ba628fa321107d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f44a8f45ed1316dbb06516e959ba628fa321107d
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Thu Dec 3 16:22:32 2020 +1300

Bug 1831415: Add condition in the query for role of people who have not
submitted pages in group

Added a condition for the role to be 'member' so that admins and tutors do not show up
in the 'members without a submission to the group' list.

Modified method documentation comments to match.

Change-Id: Ie63483d36e26766800ecc65b3802d8e9c712c37b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831415

Title:
  Exclude group tutors and admins from showing under "Members without a
  submission to the group"

Status in Mahara:
  Fix Committed

Bug description:
  When you set up a group that allows submissions (need to have admin or
  staff permissions in Mahara), you see all group members.

  However, it would be better not to show group tutors and admins as
  they usually do not need to submit portfolios.

  Instead of making it a configurable option, it would be sufficient to
  simply not show group tutors and admins.

  Group tutors only come into play when a group is set up as "course"
  group. Thus, both sets of groups will need to be tested.

  They still need to show up under those people that have submitted
  portfolios if they do do so at some stage.

  1. Create a standard group that allows submissions and set the group settings to "controlled".
  2. Add 10 people to the group.
  3. Make one of them a group admin.
  4. Go to the group homepage and see who is listed under "Members without a submission to the group".
  Expected result: You only see the regular group members.
  Actual result: You also see the 2 group admins.

  5. Change the group settings to "course" group, which now allows you to set up a group tutor.
  6. Change the role of a regular group member to that of a tutor.
  7. Go to the group homepage and see who is listed under "Members without a submission to the group".
  Expected result: You only see the regular group members.
  Actual result: You also see the 2 group admins and the tutor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831415/+subscriptions