← Back to team overview

mahara-contributors team mailing list archive

[Bug 1866779] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11484
Committed: https://git.mahara.org/mahara/mahara/commit/5d55b90c61567b8fb321304f2e578039ec673d1e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 5d55b90c61567b8fb321304f2e578039ec673d1e
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Dec 2 15:06:34 2020 +1300

Bug 1866779: moving watchlist delay notification settings

Moving the watchlist delay notification setting from site options from admin settings
to plugin administration under blocktype.

- Moved strings to the blocktype.watchlist lang strings area.
- Removed a set_config call in upgrade.php and added a post_inst method
following other blocktype plugin  post install calls instead.

- Upgrade step to transfer over old site setting 'watchnotification_delay'
to plugin admin, updating the version number too
Change-Id: If388ddd083ceb8f46026fdc138f27ca8c8da5b04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1866779

Title:
  Move 'Watchlist notification delay' out of site options and into the
  plugin administration

Status in Mahara:
  Fix Committed

Bug description:
  Currently, the 'Watchlist notification delay' is part of the 'Site
  options'. However, it would be better to keep it in a configuration
  screen in the 'Plugin administration' for this plugin, similarly to
  the forum post delay.

  Test instructions (They are written with the new categorisation
  introduced in https://reviews.mahara.org/#/c/10810/):

  1. Go to 'Admin menu' -> 'Configure site' -> 'Site options' -> Open the panel 'Site settings'.
  Expected result: The 'Watchlist notification delay' setting is not there any more.
  2. Go to 'Admin menu' -> 'Extensions -> 'Plugin administration.
  3. Navigate to 'watchlist' plugin under 'Plugin type: blocktype'.
  Expected result: There is now a configuration button with the alternative text 'Configuration for blocktype watchlist'.
  4. Click the configuration button.
  Expected result: The delay notification field is there an a numerical value can be entered as per the description.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1866779/+subscriptions


References