mahara-contributors team mailing list archive

[Mahara Bot <1911817@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11519
Committed: https://git.mahara.org/mahara/mahara/commit/3e50b1abd68a6e9b88ed97c832474677c5bc3da9
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit 3e50b1abd68a6e9b88ed97c832474677c5bc3da9
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Fri Jan 15 11:37:01 2021 +1300

Bug 1911817: User and group access roles for Edit access drop-down is
populated by more than one source

- change the way user and group roles are populated using
the same methods in from the pieform

Change-Id: If9792e783a4ec1571145941d8161ad6e2b4655ae
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit 9f25a50fa1aaadea90e2f4e6a52b3eb2e7b9a202)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1911817

Title:
  User and group access roles for Edit access drop-down is populated by
  more than one source

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed

Bug description:
  In the Edit access screen it's possible to select a person/ group and
  have a drop-down list appear populated with roles for either people or
  groups.  This data is initially set by php functions
  get_user_access_roles but is later overriden in access.json.php where
  the roles are fetched directly from the database (thus bypassing any
  filtering of results that would happen in the php function).  We
  should not use two different ways to get the data for roles.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1911817/+subscriptions