mahara-contributors team mailing list archive

[Gold <1864337@xxxxxxxxxxxxxxxxxx>]

For context this testing was done on the master branch at commit
c5824bfd3a83a7e5b168bd068fc654f0f82acecd.

Digging into this further, there was a commit 4 years ago that would
have made the scenario of the My Profile block appearing in the list
impossible.  That was on Bug 1697248 which had a large amount of
refactoring happen.  Part of that included filtering these results so
only view.type portfolio was counted.

This happened in this file/commit:
https://reviews.mahara.org/#/c/7896/31/htdocs/lib/statistics.php

Removing "AND v.type = 'portfolio'" from the query on line 472 of
lib/statistics.php does expose all of the other block types in the
results and it *does* show the [[title/blocktype.myviews]] token rather
than the actual title.  In the previously mentioned refactoring there is
code in one area that does fix this sort of thing for one other area
(see block_type_graph() in the same file) but it does not appear to be
used in the other 3 areas this sort of query is being called.

On another note, I got the Pages by type donut graph populated and can confirm that the 
[[profile/view]] token is being rendered as its actual string.

Unless further details on replicating this are presented I don't see
this being a valid bug at this point.

** Changed in: mahara
       Status: Incomplete => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1864337

Title:
  Strings missing in overview report for an institution

Status in Mahara:
  Invalid

Bug description:
  When you are on the reports page and you pull the overview report for
  an institution, there are strings missing in the "Pages overview"
  section (see screenshot). Since the screenshot was taken on a test
  site, there may be more strings missing for the blocks.

  To replicate:

  1. Create an institution on the site.
  2. Add some people to the institution.
  3. Add 2 pages to one of the member's accounts.
  4. Go to 'Admin menu' -> 'Reports' -> Click 'Configure reports' -> Select the institution -> Double-check that the report type is 'Overview' -> Click the 'Submit' button.
  Expected result: 

  1. 'My portfolios' is displayed under the heading 'Most frequently used blocks in portfolio pages'.
  2. 'Profile' is displayed under the heading 'Pages by type'.

  Actual result:

  1. '[[title/blocktype.myviews]]:' is displayed instead.
  2. '[[profile/view]]' is displayed instead.

  To test when changes have been made: Everything still displays
  correctly when 'All institutions' is selected for the report.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1864337/+subscriptions