mahara-contributors team mailing list archive

[Mahara Bot <1908845@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11548
Committed: https://git.mahara.org/mahara/mahara/commit/f28f2b92b38e9866c18522142d13ef0ff6edff40
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_STABLE

commit f28f2b92b38e9866c18522142d13ef0ff6edff40
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Mon Dec 21 15:33:01 2020 +1300

Bug 1908845: Removing the Admin Account from an institution is producing
warning

- set the user->authinstance in removeMember()

Change-Id: I34afd54149936b02b61d65cc036c0a2d4450f576
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit 8a12f7784eec89001723a93bc90eb9b1e361db8b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1908845

Title:
  Removing the Admin Account from an institution is producing warning

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  A warning is being produced when the Admin Account is removed from an
  institution via the admin/users/edit.php page:

  [WAR] af (lib/pieforms/pieform.php:1424) Invalid value for select "authinstance"
  Call stack (most recent first):

      log_message("Invalid value for select "authinstance"", 8, true, true, "/home/lisaseeto/code/mahara-catalyst/htdocs/lib/pi...", 1424) at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/errors.php:515
      error(1024, "Invalid value for select "authinstance"", "/home/lisaseeto/code/mahara-catalyst/htdocs/lib/pi...", 1424, array(size 1)) at Unknown:0
      trigger_error("Invalid value for select "authinstance"", 1024) at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/pieforms/pieform.php:1424
      Pieform::info("Invalid value for select "authinstance"") at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/pieforms/pieform/elements/select.php:152
      pieform_element_select(object(Pieform), array(size 12)) at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/pieforms/pieform.php:1601
      Pieform->build_element_html(array(size 12)) at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/pieforms/pieform.php:762
      Pieform->build() at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/pieforms/pieform.php:173
      Pieform::process(array(size 6)) at /home/lisaseeto/code/mahara-catalyst/htdocs/lib/mahara.php:5507
      pieform(array(size 6)) at /home/lisaseeto/code/mahara-catalyst/htdocs/admin/users/edit.php:343

  Steps to test:
  1. Log into site as Admin Account.
  2. On site options -> Institution settings have "People allowed multiple institutions" set to 'No'
  3. For the "No institution" (mahara) inst. settings have 'Authentication plugin' as 'Internal', 'Web services'
  4. Navigate to the admin/users/edit.php page for Admin Account (this can be done via People search)
  5. Add the account to an institution, then without refreshing the page, remove the account from that institution.
  Expected results:
  Only the session messages are returned.
  Actual results:
  A warning message is returned along with session messages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1908845/+subscriptions