← Back to team overview

mahara-contributors team mailing list archive

[Bug 1913504] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11687
Committed: https://git.mahara.org/mahara/mahara/commit/ee95f670a8b920c63336fbe87b4bc5be9af7c8fd
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit ee95f670a8b920c63336fbe87b4bc5be9af7c8fd
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Jan 28 15:37:14 2021 +1300

Bug 1913504: Updating an obsolete SQL check

Fails in postgres 12

And as vast majority of sites should be using postgres > 7 this change
shouldn't break anything as the SQL change is the same SQL in the
htdocs/lib/adodb/drivers/adodb-postgres8.inc.php file

Change-Id: Ia343acec57af31a3c1097a861a5078c4ad866aa6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 04ff5a71c2e288ee912f50de1c1963fe3deba66e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1913504

Title:
  Issues with postgres 12 and adsrc column

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  Get this error:

  EXECUTE("SELECT d.adnum as num, d.adsrc as def from pg_attrdef d,
  pg_class c where d.adrelid=c.oid and c.relname='usr_login_data' order
  by d.adnum")

   Call stack (most recent first):
    * exception(object(ADODB_Exception)) at Unknown:0
   [DBG] d3 (lib/errors.php:692) Exception thrown by smarty call while handling exception:
   [DBG] d3 (lib/errors.php:692) [ADODB_Exception]: postgres8 error: [-1: ERROR:  column d.adsrc does not exist
   [DBG] d3 (lib/errors.php:692) LINE 1: SELECT d.adnum as num, d.adsrc as def from pg_attrdef d, pg_...#012PHP message: [DBG] d3 (lib/errors.php:692)     

  To fix it we need to do the following

  https://github.com/ADOdb/ADOdb/issues/562

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1913504/+subscriptions


References