mahara-contributors team mailing list archive

[Robert Lyon <1904636@xxxxxxxxxxxxxxxxxx>]

Steps to test:

1) Add an auth instance, like ldap, to 'mahara' institution then log out

2) Go to the database and add a new fake auth, called 'cheese', which we
will have as not active - this is to simulate the scenario where an auth
method did exist (like 'browserid') but was removed.

 INSERT INTO auth_installed VALUES ('cheese', '2001010100', '0.5', 0, 0,
0);

3) Update the auth instance for the step 1 and have it use the false
auth method and be not active, eg

 UPDATE auth_instance SET authname = 'cheese', active = 0 WHERE authname
= 'ldap';

4) Go to logged out homepage

Before patch - see error: ".../htdocs/auth/cheese/lib.php did not exist"
and can't login

After patch - no error and can login

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1904636

Title:
  Only check pre-login hook if the auth method is active

Status in Mahara:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Noticed this problem when dealing with a db that had an old auth type
  in it that didn't exist on local codebase.

  When an auth method is inactive we shouldn't need to check it's
  prelogin hook

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904636/+subscriptions