mahara-contributors team mailing list archive

[Mahara Bot <1911824@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11778
Committed: https://git.mahara.org/mahara/mahara/commit/d31993ddc5dd251e52bdb46c26eb6f5fee4524f2
Submitter: Lisa Seeto (lisaseeto@xxxxxxxxxxxxxxx)
Branch:    21.04_STABLE

commit d31993ddc5dd251e52bdb46c26eb6f5fee4524f2
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Tue Jan 26 11:27:34 2021 +1300

Bug 1911824: Change the copy setting for artefact annotation to 'nocopy'

Check that $evidences exist in case there exist evidenviews but no
evidence blocks to copy

if the only block on a view is an annotation block, then make a check to not get the sql to run copies
which will result in error as there are no artefacts to copy.

Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
(cherry picked from commit cba392691da34fdf94b6053ebf57db86299a0fe3)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1911824

Title:
  When you copy a collection with SmartEvidence, all annotations come
  along as well

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  When your collection contains SmartEvidence, the annotation content
  (but not the feedback) and the annotation is set back to 'Ready for
  assessment'.

  So as not to copy somebody else's reflections, it would be better to
  not copy annotations along at all.

  When an account holder copies a collection that isn't owned by them
  containing SmartEvidence, the collection copy should not have any
  annotation blocks copied over.

  However, when the author of a collection containing SmartEvidence
  duplicates the collection, the copy shall have the annotation copied
  over from the original collection as the content inside annotation
  blocks reflect their own work.

  To replicate:

  1. Create a collection with at least one page and SmartEvidence activated.
  2. Add an annotation to one standard.
  3. Make the collection available and allow copying.
  4. Log in as somebody else and view the collection.
  5. Copy the entire collection.
  6. Go to the SmartEvidence page.
  Expected result: The SmartEvidence map is empty and there are no annotation blocks on pages.
  Actual result: The annotation blocks are still there and the status on the SmartEvidence page for them is 'Ready for assessment', i.e. the blue circle.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1911824/+subscriptions