mahara-contributors team mailing list archive

[Mahara Bot <1911824@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11782
Committed: https://git.mahara.org/mahara/mahara/commit/9969d6098b8f02a8a4d7a5d8fbfbeb76ae512a21
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 9969d6098b8f02a8a4d7a5d8fbfbeb76ae512a21
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 17 10:28:59 2021 +1200

Bug 1911824: Putting back the function that stopped feedback duplication

On the original page when copying it

To test:
- create an annotation page
- add two feedbacks to the annotation
- copy page
- view original page

Before patch
- now see there are four annotations

After patch
- still see two annotations

Change-Id: I435a53e59e20d44ad186671a7f03df199cb7d423
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1911824

Title:
  When you copy a collection with SmartEvidence, all annotations come
  along as well

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  When your collection contains SmartEvidence, the annotation content
  (but not the feedback) and the annotation is set back to 'Ready for
  assessment'.

  So as not to copy somebody else's reflections, it would be better to
  not copy annotations along at all.

  When an account holder copies a collection that isn't owned by them
  containing SmartEvidence, the collection copy should not have any
  annotation blocks copied over.

  However, when the author of a collection containing SmartEvidence
  duplicates the collection, the copy shall have the annotation copied
  over from the original collection as the content inside annotation
  blocks reflect their own work.

  To replicate:

  1. Create a collection with at least one page and SmartEvidence activated.
  2. Add an annotation to one standard.
  3. Make the collection available and allow copying.
  4. Log in as somebody else and view the collection.
  5. Copy the entire collection.
  6. Go to the SmartEvidence page.
  Expected result: The SmartEvidence map is empty and there are no annotation blocks on pages.
  Actual result: The annotation blocks are still there and the status on the SmartEvidence page for them is 'Ready for assessment', i.e. the blue circle.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1911824/+subscriptions