mahara-contributors team mailing list archive

[Mahara Bot <1935782@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11854
Committed: https://git.mahara.org/mahara/mahara/commit/f8cb41cdfdd46c132f644e258bc9cb7f3943d2a8
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f8cb41cdfdd46c132f644e258bc9cb7f3943d2a8
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Mon Jul 12 12:34:32 2021 +1200

Bug #1935782 - Skin selection selects first skin

The "Then I select the skin :skinname from :skinsection" step always
selects the first skin.

Updated the iSelectTheSkinFrom() step definition to use the $skinname in
the xpath.

Testing can be done with `./mahara_behat.sh runheadless
`user_content/create_delete_share_skin.feature.

Change-Id: I32bd072ab60a4a9798aa8611db6c69e248c7cacf

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1935782

Title:
  Behat: Skin selection always selects first skin

Status in Mahara:
  Fix Committed

Bug description:
  Adding a test for Bug #1934830 I was finding that I was unable to find
  the expected skin. This was tracked back to the following step in
  behat.

  @Then I select the skin :skinname from :skinsection

  It turns out that this particular step only ever selects the first
  skin rather than the selected skin.

  This step is defined in
  htdocs/testing/frameworks/behat/classes/BehatGeneral.php (around line
  2358 when this was posted.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1935782/+subscriptions