mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #62804
[Bug 1938975] Re: Don't send watchlist notification when block has been moved or resized
>From Robert:
In blocktype/lib.php there is a commit() function and in that is
"handle_event('blockinstancecommit', $this);" that alerts the watchlist
to send an email. So we can wrap that handle_event() in some if() check
so that only certain things like title and certain configdata change
then trigger the event.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1938975
Title:
Don't send watchlist notification when block has been moved or resized
Status in Mahara:
Confirmed
Bug description:
On a Mahara site I tested the re-arranging of blocks. Another person
had that page on their watchlist and received notifications about me
re-sizing and moving the blocks. The message was very generic: 'The
block "Title of the block" has been added or changed'
I propose not making watchlist updates when a block was simply moved
or resized but no content changed.
To test:
1. Create a page with a number of text blocks.
2. Log in as someone else and put the page onto your watchlist.
3. Log into the site on a mobile device.
4. View the page with a number of blocks on the device.
5. Login via desktop. The blocks are all squished to the left (a different issue).
6. Re-arrange the blocks to their original size and position.
7. A watchlist notification is sent.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1938975/+subscriptions
References