← Back to team overview

mahara-contributors team mailing list archive

[Bug 1930624] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11901
Committed: https://git.mahara.org/mahara/mahara/commit/e072e5412e5f7e2f792f78860d814881d03186a0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.04_STABLE

commit e072e5412e5f7e2f792f78860d814881d03186a0
Author: Lorenz Ulrich <lorenz.ulrich@xxxxxxxx>
Date:   Thu Jul 22 17:12:42 2021 +1200

Bug 1930624: Prevent touchswipe on Gridstack items

Via css

Change-Id: I9adda4b1fe27a7e0bfcc7c48a52e3f98e3fb6015
(cherry picked from commit 4a0a67c8556184d90705bac708faf7699da143f4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1930624

Title:
  Grid Stack items prevent touch swipe

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  The JQuery UI components used in Grid Stack prevent touch swipe for
  scrolling on mobile devices. The actual tiles created by Grid Stack
  contain the class "ui-draggable-handle" which disables any touch
  action:

  .ui-draggable-handle {
      -ms-touch-action: none;
      touch-action: none;
  }

  As you can see in the screenshot attached to the issue, having
  multiple tiles will confuse users because they can only scroll outside
  of the actual tile. The more width and the less space the tiles have,
  it becomes almost impossible to scroll on a smartphone.

  We used the following workaround to patch this problem:

  .grid-stack>.grid-stack-item>.grid-stack-item-content {
      touch-action: auto!important;
  }

  However it would be better to solve this cleanly.

  Mahara version: 20.04, but according to source unchanged in current
  versions

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1930624/+subscriptions



References