mahara-contributors team mailing list archive

[Ghada El-Zoghbi <1877001@xxxxxxxxxxxxxxxxxx>]

Hi @robert,

We're applied all these fixes and we're still seeing the error in the
error logs:

Aug  9 15:35:04 cff35e4bccaa ecs_mahara_prod: 2021/08/09 15:35:04 [error] 216#216: 
*2055 FastCGI sent in stderr: "PHP message: [WAR] 8b (skin/style.php:82) Undefined index: view_block_header_font
#012PHP message: Call stack (most recent first):
#012PHP message:   * log_message(string(size 39), integer, true, true, string(size 28), integer) at /var/www/site/lib/errors.php:515
#012PHP message:   * error(integer, string(size 39), string(size 28), integer, array(size 67)) at /var/www/site/skin/style.php:82
#012PHP message: 
#012PHP message: [WAR] 8b (lib/errors.php:853) Failed to get a recordset: 
postgres8 error: [-2: ERROR:  syntax error at or near "LIMIT"
#012PHP message: [WAR] 8b (lib/errors.php:853) LINE 1: SELECT * FROM "skin_fonts"  WHERE "name" = ?  LIMIT 2
#012PHP message: [WAR] 8b (lib/errors.php:853)                                                       ^] in EXECUTE("SELECT * FROM "skin_fonts"  WHERE "name" = ?  LIMIT 2")Command was: SELECT * FROM "skin_fonts"  WHERE "name" = ? 
#012PHP message: Call stack (most recent first):
#012PHP message:   * log_message(string(size 333), integer, true, true) at /var/www/site/lib/errors.php:89
#012PHP message:   * log_warn(string(size 333)) at /var/www/site/lib/errors.php:85
#012PHP message:   * SQLException->__construct(string(size 333)) at /var/www/site/lib/dml.php:541
#012PHP message:   * get_recordset_sql(string(size 45), false, integer, integer) at /var/www/site/lib/dml.php:360
#012PHP message:   * get_record_sql(string(size 45), array(size 0), integer) at /var/www/site/lib/dml.php:329
#012PHP message:   * get_record(string(size 10), string(size 4), null) at /var/www/site/lib/skin.php:606
#012PHP message:   * Skin::get_css_font_family_from_font_name(null) at /var/www/site/skin/style.php:82
#012PHP message: 
#012PHP message: [WAR] 8b (lib/dml.php:541) Failed to get a recordset: postgres8 error: [-2: ERROR:  syntax error at or near "LIMIT"
#012PHP message: [WAR] 8b (lib/dml.php:541) LINE 1: SELECT * FROM "skin_fonts"  WHERE "name" = ?  LIMIT 2
#012PHP message: [WAR] 8b (lib/dml.php:541)                                                       ^] in EXECUTE("SELECT * FROM "skin_fonts"  


I think the fix needs to also apply to htdocs/lib/skins.php line 601:


if ($font === '') {

=>

if (empty($font)) {


That should catch it when it's null, '', or not set.


Thank you.
Ghada

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1877001

Title:
  Skins not showing after upgrade

Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  When upgrading from an older site to 19.10+ site the skins stop
  showing on pages

  and there are error messages in the logs regarding this

  * error(8, "Undefined index: view_block_header_font",
  "/var/www/skin/style.php", 82, array(size 68)) at
  /var/www/skin/style.php:82

  We need an upgrade step to add in blank values for the 2 new fields

  view_block_header_font
  view_block_header_font_color

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.10/+bug/1877001/+subscriptions