mahara-contributors team mailing list archive

[Evonne Cheung <1939165@xxxxxxxxxxxxxxxxxx>]

Image gallery has now been updated so that the bootstrap carousels no
longer contradicted with it. In the update we have removed the fast-
forward icons in the gallery, which may need reviewing at a later stage
if the need arises. The arrows has been given a background to pass
contrast standards, and the captions appear below the image for the same
reason. The indications styles from bootstrap examples remain as they
currently are in bootstrap, as they don't appear in the gallery markup.

Cheers
Evonne

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1939165

Title:
  Bootstrap4 carousel doesn't render correctly

Status in Mahara:
  In Progress

Bug description:
  I tried to put a carousel into index.tpl using the example from the
  bootstrap documentation[1] but it's broken in a number of ways; the
  arrows and indicators don't render in the correct position and the
  animation does not run as expected and instead ends up as a sort of
  awkward shuffle (I can post an example if requested).

  I've narrowed down the problem to a number of overrides in the raw
  theme in Mahara which my theme is based on. If I remove the
  _carousel.scss from components/ and the carousel related code from
  _bootsrap-variables.scss and theme.js then the carousel works as
  expected. [2-4]

  A search through the commit log shows some fairly old commits related
  to carousel and image gallery.[5]

  [1] https://getbootstrap.com/docs/4.3/components/carousel/#with-indicators
  [2] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/sass/components/_carousel.scss
  [3] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/sass/utilities/_bootstrap-variables.scss#L1063
  [4] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/js/theme.js#L91
  [5] https://git.mahara.org/mahara/mahara/-/commits/master?search=carousel

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1939165/+subscriptions