← Back to team overview

mahara-contributors team mailing list archive

[Bug 1926388] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11857
Committed: https://git.mahara.org/mahara/mahara/commit/85f66e089cef70ab815886a755d46c36d6df8487
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.04_STABLE

commit 85f66e089cef70ab815886a755d46c36d6df8487
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Mon Jun 14 13:13:25 2021 +1200

Bug 1926388: Update regex (Sheets) in Google Apps block

Change-Id: I5241863a7a2ef96d6b7d17758e002dbaa76774f1
(cherry picked from commit f868e57051632b28958cddce0ef2fd3cebbe8a31)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1926388

Title:
  Google Sheets in Google Apps block not working

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  An issue was found when trying to create a Google Apps block for a
  google spreadsheet.  When pasting in the URL
  (https://docs.google.com/spreadsheets/d/e/2PACX-1vSLP46DGAOPhBqjp60r7qG6xy3nrHLGtikeSSVH9LqAP29A-Do5VCUDoKR0koK2EN820cbpgxcyxHWu/pubhtml)
  to a web browser, it had no problem displaying the document contents.

  Steps to reproduce:
  1. Log into Mahara as any user and navigate or create a new page you can edit
  2. Select a 'Google Apps' block and in the URL/Embed input enter in: https://docs.google.com/spreadsheets/d/e/2PACX-1vSLP46DGAOPhBqjp60r7qG6xy3nrHLGtikeSSVH9LqAP29A-Do5VCUDoKR0koK2EN820cbpgxcyxHWu/pubhtml, save the block & display the page
  Expected results:
  The block displays the google spreadsheet information
  Actual results:
  The block shows an error: "The file you requested does not exist".
  3. Repeat the above steps but in the URL/Embed input put in this: <iframe src="https://docs.google.com/presentation/d/e/2PACX-1vS_cNi8FtOCBaXeOz_iOMiclHMoKWTfw71ogiS3cu5-oTGcgmhT9qTj3Yg5u_dJzSfW9JaVykatXZH9/embed?start=false&loop=false&delayms=3000"; frameborder="0" width="960" height="569" allowfullscreen="true" mozallowfullscreen="true" webkitallowfullscreen="true"></iframe>
  4. Observe the same actual results from above.

  Was tested on 21.04.dev

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926388/+subscriptions