← Back to team overview

mahara-contributors team mailing list archive

[Bug 1918193] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11919
Committed: https://git.mahara.org/mahara/mahara/commit/9adec81592802b4e09e9ac62bfe1ba015d8ef86d
Submitter: Gold (gold@xxxxxxxxxxxxxxx)
Branch:    master

commit 9adec81592802b4e09e9ac62bfe1ba015d8ef86d
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Aug 11 15:33:34 2021 +1200

Bug 1918193: Add a function to allow buttons to redirect

Please test on child patches by interacting with
links that have been coverted to buttons using the
'Enter' and 'Space' keys.

This function looks for the all the data-url attributes
in the page and sets that url to be used for the target
when (buttons) are interacted with.

This is especially needed as previously <a> tag href
attributes do not get overwritten by javascript
but data-url (js attributes do) so we need a way of
telling the page to find them again.

Change-Id: I20edecb98f9056f97af89db0f76f476ab8e902f3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1918193

Title:
  Investigate buttons (forms and links)

Status in Mahara:
  In Progress

Bug description:
  Why do we have some buttons as forms and some buttons as links? Would
  we ever be able to align them so it's one thing to rule over all to
  make theming easier and more consistent?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1918193/+subscriptions