mahara-contributors team mailing list archive

[Mahara Bot <1873119@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11527
Committed: https://git.mahara.org/mahara/mahara/commit/8df346978c4af1f9dea4dc1b04cd9aea99968a65
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 8df346978c4af1f9dea4dc1b04cd9aea99968a65
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Mon Dec 21 09:24:28 2020 +1300

Bug 1873119: Adding artefact comments in the pdf export

Fix up formatting of comments on HTML export

Replace 'file' lang key calls to use to use the 'File' key instead so
I can use 'file' key to get 'file' string with lower caps along with
other plugin lang strings without lowercase titles to use mid-sentence.

Profile pictures in comments are not showing up - but unrelated to this
bug

Additional typos fixed

Removed the metadata class for comment privacy note

Change-Id: I5c2dc52670b4fcd83347eb56cb5ac743a13bc94f

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1873119

Title:
  Artefact + general comments are they appearing in HTML / PDF exports

Status in Mahara:
  In Progress

Bug description:
  If they are appearing in HTML export in a modal then we need to get
  them to appear in PDF a different way (probably appended to the page
  comments)

  The HTML export area for comments is out of date, also which is used
  by the PDF also. The formatting needs to be updated.

  Additional to this, adding a switch to allow private-comment-free
  exports.

  To test this:

  1. Create a page with multiple blocks
  2. Make comments to the artefacts displaying in the blocks - using a combination of the 'details' view as well as adding private and public comments
  3. Export the page with the 'Include comments' ON and 'Include private comments OFF'
     - ✅ CHECK when 'Include comments' is OFF, 'Include private comments' switch is disabled
  4. ✅ EXPECT - none of the private comments in the PDF export at the base page where the page comments sit.
  6. ✅ EXPECT - the artefacts comments do not appear on the HTML export and only the PDF export 
  7. Export the page again with 'Include comments' ON and 'Include private comments' ON
  8. ✅ EXPECT - the private comments appear in the PDF export with a  grey background

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1873119/+subscriptions