mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #63079
[Bug 1942268] A patch has been submitted for review
Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11973
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1942268
Title:
Making 'Delete standard' and 'Delete standard element' button on
SmartEvidence Editor translatable.
Status in Mahara:
Fix Committed
Status in Mahara 20.10 series:
New
Status in Mahara 21.04 series:
New
Status in Mahara 21.10 series:
Fix Committed
Bug description:
I think it's better for us to make 'Delete standard' and 'Delete
standard element' button on SmartEvidence Editor translatable as
below.
File to modify:
htdocs/module/framework/frameworks.php
Line:
170
[ Before ]
'removestandardorelementconfirm' => 'module.framework'
);
[ After ]
'removestandardorelementconfirm' => 'module.framework',
'delete' => 'module.framework'
);
--------------------------
File to modify:
htdocs/module/framework/lang/en.utf8/module.framework.php
Line:
133
[ Before ]
$string['missingrecordsdb'] = 'The following records could not be found on the DB: %s';
[ After ]
$string['missingrecordsdb'] = 'The following records could not be found on the DB: %s';
$string['delete'] = 'Delete %s';
--------------------------
File to modify:
htdocs/module/framework/js/editor.js
Line:
56
[ Before ]
JSONEditor.defaults.languages.en.remove_element_message = get_string('removestandardorelementconfirm');
// Enable select2
JSONEditor.plugins.select2.enable = true;
[ After ]
JSONEditor.defaults.languages.en.remove_element_message = get_string('removestandardorelementconfirm');
JSONEditor.defaults.languages.en.button_delete_row_title = get_string('delete','module.framework','{{0}}');
// Enable select2
JSONEditor.plugins.select2.enable = true;
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1942268/+subscriptions
References