← Back to team overview

mahara-contributors team mailing list archive

[Bug 1940447] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11986
Committed: https://git.mahara.org/mahara/mahara/commit/0dd420046a7f5690577c584083f3a1fea66691a3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.04_STABLE

commit 0dd420046a7f5690577c584083f3a1fea66691a3
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Thu Sep 9 16:03:56 2021 +1200

Bug 1940447: Fix getting openbadge block js

Generic fix inside the get_all_blocktype_javascript function

Change-Id: Ib5baa5a2a9b1da3dbf0b416cdf27772d3a1e5ba5
(cherry picked from commit 6daf64583854adf5151eb331dc5840e5c539d614)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1940447

Title:
  Open Badge details aren't shown

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  Create a new page and add an open badges block. 
  Fill in badges, in our case from openbadgepassport. 
  View that page.
  Clicking on an open badge does not open a modal but gives an error message in the browsers console:

  Uncaught ReferenceError: showBadgeContent is not defined
      at HTMLImageElement.<anonymous> (<anonymous>:5:17)
      at HTMLDivElement.dispatch (jquery.js?v=8252:2)
      at HTMLDivElement.v.handle (jquery.js?v=8252:2)
  (anonymous) @ VM917:5
  dispatch @ jquery.js?v=8252:2
  v.handle @ jquery.js?v=8252:2

  Mahara 21.04.1 on Ubuntu 20.04 LTS
  nginx
  MariaDB 10.3
  Firefox 91.0 / Chrome 92.0.4515.131

  Same problem on current demo.mahara.org site

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1940447/+subscriptions



References