mahara-contributors team mailing list archive

[Kristina Hoeppner <1943792@xxxxxxxxxxxxxxxxxx>]

Mōrena Jeremy,

Thank you very much for the patch. We'll add it to our code review
system. If you wish to push it there next time directly, you are welcome
to set up the connection to Gerrit for a more streamlined workflow:
https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code

Ngā mihi
Kristina

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1943792

Title:
  Remote (MNet) collection submissions fail to release

Status in Mahara:
  In Progress
Status in Mahara 20.04 series:
  Triaged
Status in Mahara 20.10 series:
  Triaged
Status in Mahara 21.04 series:
  Triaged
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Mahara 21.04.1
  Totara 12.?
  Mahara assignment submission 2017101601

  Set up MNet Connection from a Moodle/ Totara to Mahara allowing users from Moodle to log in to Mahara
  Install Mahara assignment submissions plugin to the Moodle site.
  Set up an assignment allowing Mahara submissions
   - lock submitted pages after grading

  
  Create a collection as a learner
  Log in to Moodle 
  Submit a Mahara collection to the assignment

  Log out

  Log in to Moodle as a teacher who does not have an account on Mahara
  Grade the submitted assignment and allow a new attempt

  Expected
  The collection and pages are released and a new attempt is available

  Actual
  Error is returned: optional_userobj no userid and no logged in user

  
  ----

  Diagnosis
  In /lib/collection.php relase()
  $releaseuser = optional_userobj($releaseuser);  

  $releaseuser does not exist. 
  Called in xmlrpc/lib.php release_submitted_view() 
  find_remote_user($teacherusername, $REMOTEWWWROOT)
  returns no user.

  This was introduced in 87f0664d3bae37184581425a995a6a534dc16c39 Bug
  1908837: Setting $releaseuser correctly

  Suggested fix
  In /lib/collection.php relase()
  wrap $releaseuser = optional_userobj($releaseuser);  in an if statement

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1943792/+subscriptions