mahara-contributors team mailing list archive

[Mahara Bot <1939165@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11995
Committed: https://git.mahara.org/mahara/mahara/commit/940dce536191e188f67578fcafc1a2a05f1fd528
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 940dce536191e188f67578fcafc1a2a05f1fd528
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Mon Sep 13 11:01:32 2021 +1200

Bug 1939165 Bootstrap4 carousel styling fixes #2

Adding a clearer which fixes the indicators on dashboard if it's
placed under the three dashboard boxes. Also removed text decoration
on the indicators.

behatnotneeded

Change-Id: Ic2a4ebc7d9462949af334f0c21576d36e5e03f60

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1939165

Title:
  Bootstrap4 carousel doesn't render correctly

Status in Mahara:
  Fix Committed

Bug description:
  I tried to put a carousel into index.tpl using the example from the
  bootstrap documentation[1] but it's broken in a number of ways; the
  arrows and indicators don't render in the correct position and the
  animation does not run as expected and instead ends up as a sort of
  awkward shuffle (I can post an example if requested).

  I've narrowed down the problem to a number of overrides in the raw
  theme in Mahara which my theme is based on. If I remove the
  _carousel.scss from components/ and the carousel related code from
  _bootsrap-variables.scss and theme.js then the carousel works as
  expected. [2-4]

  A search through the commit log shows some fairly old commits related
  to carousel and image gallery.[5]

  [1] https://getbootstrap.com/docs/4.3/components/carousel/#with-indicators
  [2] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/sass/components/_carousel.scss
  [3] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/sass/utilities/_bootstrap-variables.scss#L1063
  [4] https://git.mahara.org/mahara/mahara/-/blob/master/htdocs/theme/raw/js/theme.js#L91
  [5] https://git.mahara.org/mahara/mahara/-/commits/master?search=carousel

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1939165/+subscriptions