mahara-contributors team mailing list archive

[Mahara Bot <1918423@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11865
Committed: https://git.mahara.org/mahara/mahara/commit/da2f64cb524225540d3c39c43120b10e8c7eea22
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit da2f64cb524225540d3c39c43120b10e8c7eea22
Author: Joost Elshoff <j.elshoff@xxxxxxxxxx>
Date:   Mon Jul 19 15:43:43 2021 +1200

Bug 1918423: Missing function generate_simple_struct_class in soap
webservice in /webservice/soap/locallib.php

- Re-ordered to match moodle_31 ordering where we have copied code.
- Additional documentation copied over from moodle_31

The following functions live in webservice/lib.php in moodle_31
but got ported into soap/locallib.php in the past so I've left them as
is but re-ordered them to match the original code.
- init_service_class
- service_class_method_body
- get_phpdoc_type
- get_virtual_method_code
- init_service_class
Change-Id: Ieb204161d170fe601169bbb679a7f0ef3e8031f0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1918423

Title:
  Missing function generate_simple_struct_class in soap webservice in
  /webservice/soap/locallib.php

Status in Mahara:
  Fix Committed

Bug description:
  When using the webservice with the following methods

  mahara_institution_add_members, mahara_institution_decline_members,
  mahara_institution_get_members, mahara_institution_get_requests,
  mahara_institution_invite_members, mahara_institution_remove_members,
  mahara_user_get_users, mahara_user_get_users_by_id,
  mahara_user_create_users

  we get the following error in the wsdl
  /webservice/soap/server.php?wstoken=<token>&wsdl=1

  <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/";>
  <SOAP-ENV:Body>
  <SOAP-ENV:Fault>
  <faultcode>MOODLE:error</faultcode>
  <faultstring>Call to undefined method webservice_soap_server::generate_simple_struct_class()</faultstring>
  </SOAP-ENV:Fault>
  </SOAP-ENV:Body>
  </SOAP-ENV:Envelope>

  This function (generate_simple_struct_class) is called in the file
  /webservice/soap/locallib.php on line 341

      protected function get_phpdoc_type($keydesc) {
  ...
          else if ($keydesc instanceof external_single_structure) {
              $type = $this->generate_simple_struct_class($keydesc); // <<<
          }
  ...
      }

  however the function generate_simple_struct_class is missing in this
  class.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1918423/+subscriptions