mahara-contributors team mailing list archive

[Mahara Bot <1940800@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12055
Committed: https://git.mahara.org/mahara/mahara/commit/656699113c7365465e438a66f61b65079508c36e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 656699113c7365465e438a66f61b65079508c36e
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Sep 22 17:09:30 2021 +1200

Bug 1940800: Merge moderate/comment notifications

Instead of having two notifications, one for moderating
a comment and for a new comment, combine them into one.

Change-Id: Ifd7db976b1e3dbbea87893c4282b0cbc5b4a795a
(cherry picked from commit f823eff01b357904c11050ccfd074e59f78a2205)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1940800

Title:
  Comments for moderation are not identified to portfolio author

Status in Mahara:
  Fix Committed

Bug description:
  This is related to bug #1940798

  When comment moderation is turned on, the portfolio author receives
  two notifications: One with the comment itself and one with the info
  that a comment needs to be moderated. The notification links not
  working correctly is dealt with in bug #1940798.

  Here I'm addressing the fact that the portfolio author doesn't have an
  indicator which comment should be moderated on a page. Additionally,
  there are two notifications sent for a comment that is awaiting
  moderation. Ideally, only one notification is sent out for each new
  comment that is added.

  To replicate:

  1. PersonA creates a page and includes an image that allows comments.
  2. PersonA shares the page with PersonB and allows comments in 'Advanced options' and switches 'Moderate comments' to 'Yes' as well.
  3. Log in as PersonB and leave a public comment on the page and on the artefact. You see "This comment is private. You have requested that this comment be made public."
  4. Log in as PersonA.
  5. PersonA received 2 notifications: 1) The comment itself, 2) The notification about making the comment public.
  6. PersonA finds the comments that need moderation.

  Expected result: There is a sentence like 'This comment is private.
  The comment author requested that this comment be made public.' next
  to the 'Make public' button to indicate to the portfolio author more
  easily, which comment can be made public rather than making a purely
  private comment public.

  Actual result: There is only the general private comment info 'This
  comment is private' with a 'Make public' button.

  It would also be better if there was only one notification for the
  comment that needs moderation: It includes the comment and the
  information about the moderation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1940800/+subscriptions