← Back to team overview

mahara-contributors team mailing list archive

[Bug 1946046] A change has been merged

 

Reviewed:  https://reviews.mahara.org/12140
Committed: https://git.mahara.org/mahara/mahara/commit/0dddd74dd6bcef3b327d40e50d88fdfd2bc06b10
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 0dddd74dd6bcef3b327d40e50d88fdfd2bc06b10
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 7 15:28:09 2021 +1300

Bug 1946046: Exporting PDF block correctly

Fixing the problem with exporting PDF block after the upgrade to
PDF.js v2.8.335

Change-Id: I0750f94e54bd68f6c2042ff4a2fa2239e8ddf9b6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 9a0ca5243438a00c940b497c6fd677409862e832)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1946046

Title:
  PDFs in PDF artifacts are not exporting to HTML

Status in Mahara:
  In Progress

Bug description:
  This looks to be a regression of the following:

  https://bugs.launchpad.net/mahara/+bug/1698699

  When testing PDF exports to HTML I found the PDF in the artifact block
  was not being linked to a local file when viewing
  file:///path/to/extracted/index.html

  The block and iframe are present and the iframe is pointing to the the
  artefact on the site that generated the export.

  The iframe is, correctly, showing a '[site] refused to connect' error.

  Testing:
  Create a Page.  Add a PDF block, upload a PDF, save the block.

  Export the Page.

  Extract the zip and open the index.html file in the HTML directory.

  Expected outcome: The PDF is presented in the block in the browser.
  Actual outcome: The link points to the site the archive is from and the browser blocks it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1946046/+subscriptions



References