mahara-contributors team mailing list archive

[Mahara Bot <1947529@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12155
Committed: https://git.mahara.org/mahara/mahara/commit/e77c422408f2d58e0af128cfb41d1e931e66bb6f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit e77c422408f2d58e0af128cfb41d1e931e66bb6f
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Mon Oct 18 15:05:11 2021 +1300

Bug #1947529: Fallback for 'External apps' lang strings

Check that a lang string exists before
displaying names of web services. If
not, display the service name as entered
when setting it up.

Change-Id: I136caa683f0285bb4d93305603890b41adb05d98

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1947529

Title:
  Manually set up web services display as missing strings

Status in Mahara:
  Fix Committed

Bug description:
  This is a regression introduced through
  https://reviews.mahara.org/12041

  At the moment, all web services groups set up in the web services
  configuration are displayed in the 'Externa apps' options drop-down
  menu. This issue will be addressed in bug #1947533. For the time being
  for 21.10 we will need to fix the missing strings.

  To replicate:

  1. As site admin go to Admin menu -> Web services -> Configuration.
  2. Under 'Manage service groups' create a new one, enable it and allow a single web services function.
  3. Go to Admin menu -> Web services -> External apps and look at the drop-down menu where all available web services are listed.

  Expected result: The newly created web services is listed with its title.
  Actual result: There is a missing language string.

  To do: If there is no language string for a web service that is
  displayed in that drop-down menu, use the one that is saved in the
  database. This is usually the case if there is no particular module
  for it but when it is created on the fly.

  BTW, the missing LTI Advantage string is already deal with in bug
  1947522.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1947529/+subscriptions