mahara-contributors team mailing list archive

[Mahara Bot <1947625@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12173
Committed: https://git.mahara.org/mahara/mahara/commit/d527f268e8f9938a1ce9a6ef2b41d9be01084201
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit d527f268e8f9938a1ce9a6ef2b41d9be01084201
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Thu Oct 21 11:45:19 2021 +1300

Bug 1947625 'Edit group membership' overlapping long text

behatnotneeded

Change-Id: Iabc29814ef6915dff516e0c92f90a98733568bea
(cherry picked from commit 5377061bde55d9ae3e101760946ab3bb53b13f2d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1947625

Title:
  'Edit group membership' screen has overlapping text with long group
  names

Status in Mahara:
  Fix Committed

Bug description:
  Reported at https://mahara.org/interaction/forum/topic.php?id=8939

  It looks like there is no provision to handle long group names
  gracefully, i.e. wrap them when you try to add them via 'Edit group
  membership' on Main menu -> Engage -> People.

  To replicate:

  1. Upload the attached CSV file with group names.
  2. Add at least one other person to the site.
  3. As site admin, go to Main menu -> Engage -> People and click 'Edit group membership' next to the other person.

  Expected result: The modal displays all groups under 'Add members' and 'Invite' in a readable fashion.
  Actual result: The group names overlap. See the screenshot on the forum topic.

  The group names should wrap because they tend to be the same at the
  start and only differ towards the end. That's why an ellipses wouldn't
  be a good option.

  There are also a couple of accessibility issues:

  1. There are two buttons with 'btn-primary'. Since there is no real primary button, they should both have the normal grey button color.
  2. Both buttons are called 'Apply changes' without any additional marker (I think) to indicate which one is which. I think it would be better to call the first one 'Add to group' and the second one 'Invite to group'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1947625/+subscriptions