← Back to team overview

mahara-contributors team mailing list archive

[Bug 1489259] A change has been merged

 

Reviewed:  https://reviews.mahara.org/12172
Committed: https://git.mahara.org/mahara/mahara/commit/db272d717c470cd0744970673d798482c92a73c2
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit db272d717c470cd0744970673d798482c92a73c2
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Tue Sep 14 10:42:34 2021 +1200

Bug #1489259: Make buttons under iframe sources accessible

Give edit/delete icon buttons a title attribute
for screenreaders and remove obsolete span tags

Add info to styleguide

Change-Id: Ice0eafa8aa39ab03be12c4a574df160c0b70fdd4
(cherry picked from commit b40731f7b2deac376eb5c1504d9ef5ee946cf356)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1489259

Title:
  Edit/delete buttons under iframe sources are not accessible

Status in Mahara:
  Fix Committed

Bug description:
  In Administration -> Allowed iframe sources, the accessibility
  features of the edit and delete buttons in the table are somewhat
  inconsistent, and the edit button is actually broken. In particular:

  - When using JAWS, pressing Enter on the edit button jumps to the top of the page instead of opening the edit form
  - The edit button is actually a link - since it modifies the current page it would make more sense as a button
  - The edit button is descriptive (it contains the name of the row it's deleting) but the delete button isn't

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1489259/+subscriptions



References